Expand scf dialect implementation #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
reviewed
Oct 1, 2024
tests/test_scf.py
Outdated
Comment on lines
54
to
58
| if len(sys.argv) > 1: | ||
| exec(sys.argv[1]) | ||
| else: | ||
| from pytest import main | ||
| main([__file__]) |
There was a problem hiding this comment.
Suggested change
| if len(sys.argv) > 1: | |
| exec(sys.argv[1]) | |
| else: | |
| from pytest import main | |
| main([__file__]) | |
| from pytest import main | |
| main([__file__]) |
Please don't add exec calls into the code (even if it's a main function of a test file). Thanks!
There was a problem hiding this comment.
Copied this from test_linalg.py, so I'll make the change there too.
There was a problem hiding this comment.
And test_builder.py
mlir/dialects/func.py
Outdated
| @@ -23,7 +23,7 @@ class CallIndirectOperation(DialectOp): | |||
| @dataclass | |||
| class CallOperation(DialectOp): | |||
| func: mast.SymbolRefId | |||
| type: mast.FunctionType | |||
| type: Optional[mast.FunctionType] = None | |||
There was a problem hiding this comment.
should there not be an accompanying lark change for this? Also, why would calls not have type information? Is that a new addition to MLIR?
There was a problem hiding this comment.
This was probably a copy-paste problem with argtypes being a duplicate of type. It should just be using type in both syntaxes.
Will clean up the unused argtypes in CallIndirectOperation too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
condition,whileandyieldopsiffor,ifandwhileusing examples from https://mlir.llvm.org/docs/Dialects/SCFDialect/forroundtrip)